E2E: improve CLI log format#7364
Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0420-E2E-utility-cleanup-allfrom
Open
E2E: improve CLI log format#7364phyllis-sy-wu wants to merge 1 commit intopsyw-0420-E2E-utility-cleanup-allfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0420-E2E-utility-cleanup-allfrom
Conversation
This was referenced Apr 22, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
4 tasks
f569707 to
b6b2479
Compare
9d0a3aa to
bfb1932
Compare
b6b2479 to
a7aea9b
Compare
bfb1932 to
402ec4e
Compare
a7aea9b to
d892ee8
Compare
402ec4e to
21fd11c
Compare
d892ee8 to
f8430c6
Compare
21fd11c to
9ff8224
Compare
f8430c6 to
50e9c65
Compare
9ff8224 to
d2b07be
Compare
d2b07be to
71cf082
Compare
50e9c65 to
20863dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
E2E debug output was hard to read and didn't match what you see when running a CLI command manually:
--path(e.g. a temp-dir app) you'd have to scroll horizontally to find the actual subcommand.DEBUG=1,execabuffered stdout/stderr and only surfaced them after the subprocess finished. You couldn't watch CLI info boxes, success panels, or progress messages as the test ran — only a wall of text after each command completed.WHAT is this pull request doing?
exec:/spawn:entry is now split onto two lines — binary path on one, args on the next. The subcommand is the first thing you see on the args line:DEBUG=1. NewrunExecahelper pipes subprocessstdout/stderrto the parent with{end: false}(so the parent's streams aren't closed when the subprocess exits). execa still buffers internally, so capturedresult.stdout/result.stderrfor assertions is unchanged. Applied to bothexecandexecCreateApp.Net effect: running E2E tests with
DEBUG=1now streams the same info boxes, success panels, and progress messages you'd see running `shopify app deploy ...` manually, rather than a silent wait followed by a dump.How to test your changes?
Expect to see:
Checklist